fey.naomi/fennel-ls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

simplify unknown module code

Browse Source
This commit is contained in:
XeroOl 2025-08-22 19:03:09 -05:00
parent 13b75260b2
commit 6b5f787bc9
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/fennel-ls/lint.fnl
View File

@ -132,10 +132,10 @@ You can read more about how to add lints in docs/linting.md"
(accumulate [in? false call (pairs calls) &until in?] (accumulate [in? false call (pairs calls) &until in?]
(and (sym? (. call 1) :or) (utils.find call symbol)))) (and (sym? (. call 1) :or) (utils.find call symbol))))
(fn unknown-module-field [server file symbol ?ast ?stack] (fn unknown-module-field [server file symbol]
"if ?ast is a module field that isn't known, return a diagnostic" "if ?ast is a module field that isn't known, return a diagnostic"
(let [opts {} (let [opts {}
item (analyzer.search server file ?ast opts {:stack ?stack})] item (analyzer.search server file symbol opts {})]
(if (and (not item) (if (and (not item)
(not (in-or? file.calls symbol)) (not (in-or? file.calls symbol))
;; this doesn't necessarily have to come thru require; it works ;; this doesn't necessarily have to come thru require; it works
@ -174,16 +174,16 @@ You can read more about how to add lints in docs/linting.md"
:since "0.1.0" :since "0.1.0"
:type :reference :type :reference
:impl (fn [server file symbol] :impl (fn [server file symbol]
;; only multisyms, like `my-module.field` ;; references, like `my-module.field`
;; we only need to check multisyms, ie ones doing indexing
(if (. (utils.multi-sym-split symbol) 2) (if (. (utils.multi-sym-split symbol) 2)
(unknown-module-field server file symbol symbol)))} (unknown-module-field server file symbol)))}
{:type :definition {:type :definition
:impl (fn [server file symbol definition] :impl (fn [server file symbol definition]
;; definitions, like `(local {: field} (require :my-module))` ;; definitions, like `(local {: field} (require :my-module))`
(if definition.keys ;; we only need to check ones with keys, ie ones doing indexing
(unknown-module-field server file symbol definition.definition (when definition.keys
(fcollect [i (length definition.keys) 1 -1] (unknown-module-field server file symbol)))})
(. definition.keys i)))))})
(add-lint :unnecessary-method (add-lint :unnecessary-method
{:what-it-does {:what-it-does