fey.naomi/fennel-ls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tset lint should only apply when rewriting as sym is valid

Browse Source
This commit is contained in:
XeroOl 2024-12-28 14:34:44 -06:00
parent 4bfa344b0e
commit 7f15f64e22
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/fennel-ls/lint.fnl
View File

@ -25,6 +25,10 @@ the `file.diagnostics` field, filling it with diagnostics."
(. ops (tostring item))
item))
(fn could-be-rewritten-as-sym? [str]
(and (= :string (type str))
(not (str:find "[^!$%*+/0-9<=>?A-Z\\^_a-z|\128-\255-]"))))
(λ unused-definition [server file symbol definition]
"local variable that is defined but not used"
(if (not (or (= "_" (: (tostring symbol) :sub 1 1))
@ -72,9 +76,7 @@ the `file.diagnostics` field, filling it with diagnostics."
(sym? (. call 2))
(. file.lexical call))
(let [method (. call 3)]
(if (and (= :string (type method))
(not (method:find "^[0-9]"))
(not (method:find "[^!$%*+-/0-9<=>?A-Z\\^_a-z|\128-\255]")))
(if (could-be-rewritten-as-sym? method)
{:range (message.ast->range server file call)
:message (.. "unnecessary : call: use (" (tostring (. call 2)) ":" method ")")
:severity message.severity.WARN
@ -82,8 +84,10 @@ the `file.diagnostics` field, filling it with diagnostics."
:codeDescription "unnecessary-method"}))))
(λ unnecessary-tset [server file head call]
(if (and (sym? head :tset) (sym? (. call 2))
(= :string (type (. call 3))) (. file.lexical call))
(if (and (sym? head :tset)
(sym? (. call 2))
(could-be-rewritten-as-sym? (. call 3))
(. file.lexical call))
(diagnostic {:range (message.ast->range server file call)
:message (string.format "unnecessary %s" head)
:severity message.severity.WARN

5
test/lint.fnl
View File

@ -177,6 +177,11 @@
:message "unnecessary tset"
:range {:start {:character 15 :line 0}
:end {:character 32 :line 0}}}])
;; Lint only triggers on keys that can be written as a sym
(check "(local tbl {}) (tset tbl \"hello-world\" 249)" [{:code 309}])
(check "(local tbl {}) (tset tbl \"01234567\" 249)" [{:code 309}])
(assert-ok "(local tbl {}) (tset tbl \"hello world\" 1)")
(assert-ok "(local tbl {}) (tset tbl \"0123.4567\" 1)")
nil)
(fn test-unnecessary-do []