fey.naomi/fennel-ls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(and) and (or) are covered by unpack diagnostic

Browse Source
This commit is contained in:
XeroOl 2024-02-10 01:06:21 -06:00
parent a973de5f87
commit a3dcd92e85
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/fennel-ls/diagnostics.fnl
View File

@ -52,7 +52,7 @@ the `file.diagnostics` field, filling it with diagnostics."
:code 303 :code 303
:codeDescription "unnecessary-method"})))) :codeDescription "unnecessary-method"}))))
(local ops {"+" 1 "-" 1 "*" 1 "/" 1 "//" 1 "%" 1 ".." 1}) (local ops {"+" 1 "-" 1 "*" 1 "/" 1 "//" 1 "%" 1 ".." 1 "and" 1 "or" 1})
(λ bad-unpack [self file] (λ bad-unpack [self file]
"an unpack call leading into an operator" "an unpack call leading into an operator"
(icollect [[op &as call] (pairs file.calls) (icollect [[op &as call] (pairs file.calls)
@ -72,7 +72,7 @@ the `file.diagnostics` field, filling it with diagnostics."
(if (fennel.sym? op "..") (if (fennel.sym? op "..")
(let [unpackme (fennel.view (. call (length call) 2))] (let [unpackme (fennel.view (. call (length call) 2))]
(.. " Use (table.concat " unpackme ") instead of (.. (unpack " unpackme "))")) (.. " Use (table.concat " unpackme ") instead of (.. (unpack " unpackme "))"))
(.. " Use a loop when you have a dynamic number of arguments to " (tostring op)))) (.. " Use a loop when you have a dynamic number of arguments to (" (tostring op) ")")))
:severity message.severity.WARN :severity message.severity.WARN
:code 304 :code 304
:codeDescription "bad-unpack"})))) :codeDescription "bad-unpack"}))))