fey.naomi/fennel-ls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add no-decreasing-comparison lint (off by default)

Browse Source
This commit is contained in:
Phil Hagelberg 2025-01-11 20:57:43 -08:00
parent 7da1c60e96
commit b0e7921715
2 changed files with 33 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/fennel-ls/config.fnl
View File

@ -30,7 +30,8 @@ There are no global settings. They're all stored in the `server` object.
:bad-unpack (option true) :bad-unpack (option true)
:var-never-set (option true) :var-never-set (option true)
:op-with-no-arguments (option true) :op-with-no-arguments (option true)
:multival-in-middle-of-call (option true)} :multival-in-middle-of-call (option true)
:no-decreasing-comparison (option false)}
:libraries {:love2d (option false) :tic-80 (option false)} :libraries {:love2d (option false) :tic-80 (option false)}
:extra-globals (option "")}) :extra-globals (option "")})

38
src/fennel-ls/lint.fnl
View File

@ -2,7 +2,8 @@
Provides the function (check server file), which goes through a file and mutates Provides the function (check server file), which goes through a file and mutates
the `file.diagnostics` field, filling it with diagnostics." the `file.diagnostics` field, filling it with diagnostics."
(local {: sym? : list? : table? : view &as fennel} (require :fennel)) (local {: sym? : list? : table? : view
: sym : list &as fennel} (require :fennel))
(local {:scopes {:global {: specials}}} (require :fennel.compiler)) (local {:scopes {:global {: specials}}} (require :fennel.compiler))
(local analyzer (require :fennel-ls.analyzer)) (local analyzer (require :fennel-ls.analyzer))
(local message (require :fennel-ls.message)) (local message (require :fennel-ls.message))
@ -193,6 +194,21 @@ the `file.diagnostics` field, filling it with diagnostics."
#[{:range (message.ast->range server file call) #[{:range (message.ast->range server file call)
:newText (view identity)}])))) :newText (view identity)}]))))
(λ no-decreasing-comparison [server file op call]
(if (or (sym? op :>) (sym? op :>=))
(diagnostic
{:range (message.ast->range server file call)
:message "Use increasing operator instead of decreasing"
:severity message.severity.WARN
:code 312
:codeDescription "no-decreasing-comparison"}
#[{:range (message.ast->range server file call)
:newText (let [new (if (sym? op :>=) (fennel.sym :<=) (fennel.sym :<))
reversed (fcollect [i (length call) 2 -1
&into (list (sym new))]
(. call i))]
(view reversed))}])))
(λ match-reference? [ast references] (λ match-reference? [ast references]
(if (sym? ast) (?. references ast :target) (if (sym? ast) (?. references ast :target)
(or (table? ast) (list? ast)) (or (table? ast) (list? ast))
@ -246,12 +262,20 @@ the `file.diagnostics` field, filling it with diagnostics."
;; all non-macro calls. This only covers specials and function calls. ;; all non-macro calls. This only covers specials and function calls.
(each [[head &as call] (pairs file.calls)] (each [[head &as call] (pairs file.calls)]
(when head (when head
(when lints.bad-unpack (table.insert diagnostics (bad-unpack server file head call))) (when lints.bad-unpack
(when lints.unnecessary-method (table.insert diagnostics (unnecessary-method server file head call))) (table.insert diagnostics (bad-unpack server file head call)))
(when lints.unnecessary-do (table.insert diagnostics (unnecessary-do-values server file head call))) (when lints.unnecessary-method
(when lints.unnecessary-tset (table.insert diagnostics (unnecessary-tset server file head call))) (table.insert diagnostics (unnecessary-method server file head call)))
(when lints.redundant-do (table.insert diagnostics (redundant-do server file head call))) (when lints.unnecessary-do
(when lints.op-with-no-arguments (table.insert diagnostics (op-with-no-arguments server file head call))) (table.insert diagnostics (unnecessary-do-values server file head call)))
(when lints.unnecessary-tset
(table.insert diagnostics (unnecessary-tset server file head call)))
(when lints.redundant-do
(table.insert diagnostics (redundant-do server file head call)))
(when lints.op-with-no-arguments
(table.insert diagnostics (op-with-no-arguments server file head call)))
(when lints.no-decreasing-comparison
(table.insert diagnostics (no-decreasing-comparison server file head call)))
;; argument lints ;; argument lints
;; every argument to a special or a function call ;; every argument to a special or a function call