fey.naomi/fennel-ls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

make fennel-ls crash a bit less

Browse Source
This commit is contained in:
XeroOl 2023-06-09 01:36:59 -05:00
parent 3c79f480a8
commit e5742bbc4e
3 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -25,7 +25,7 @@ clean:
rm -f $(EXE) rm -f $(EXE)
test: test:
LUA_PATH="./src/?.lua;./?.lua" FENNEL_PATH="./src/?.fnl;./?.fnl" \ TESTING=1 LUA_PATH="./src/?.lua;./?.lua" FENNEL_PATH="./src/?.fnl;./?.fnl" \
$(FENNEL) test/init.fnl $(FENNEL) test/init.fnl
install: $(EXE) install: $(EXE)

13
TODO.md
View File

@ -15,8 +15,8 @@ Here is my feature wishlist. I don't expect to ever get all of this done, but th
- [X] Neovim (This project isn't a neovim plugin, but there are instructions on how to inform neovim of the fennel-ls binary once you build it.) - [X] Neovim (This project isn't a neovim plugin, but there are instructions on how to inform neovim of the fennel-ls binary once you build it.)
- [X] emacs - [X] emacs
- [X] helix - [X] helix
- [ ] vscode - [ ] vscode (publish an extension)
- [ ] vim+coc - [ ] vim+coc (publish a node thingy)
- [x] Go-to-definition: - [x] Go-to-definition:
- [X] literal table constructor - [X] literal table constructor
- [X] table destructuring - [X] table destructuring
@ -36,12 +36,12 @@ Here is my feature wishlist. I don't expect to ever get all of this done, but th
- [ ] Completion Suggestions - [ ] Completion Suggestions
- [X] from globals - [X] from globals
- [X] from current scope - [X] from current scope
- [ ] from macros (only on first form in a list) - [X] from macros (only on first form in a list)
- [ ] from specials (only on first form in a list) - [X] from specials (only on first form in a list)
- [X] "dot completion" for table fields - [X] "dot completion" for table fields
- [ ] dot completion is aware of a stdlib - [ ] dot completion is aware of a stdlib
- [ ] actually compliant rules about lexical scope (only see things declared before, not after) - [ ] actually compliant rules about lexical scope (only see things declared before, not after)
- [ ] show docs/icons on each suggestion - [x] show docs/icons on each suggestion
- [ ] "dot completion" for metatable `__index` fields - [ ] "dot completion" for metatable `__index` fields
- [ ] `(. obj :` string completions - [ ] `(. obj :` string completions
- [ ] `(: "foo" :` string completions - [ ] `(: "foo" :` string completions
@ -52,6 +52,7 @@ Here is my feature wishlist. I don't expect to ever get all of this done, but th
- [X] Report more than one error per top-level form - [X] Report more than one error per top-level form
- [ ] Reports linting issues - [ ] Reports linting issues
- [X] Unused locals - [X] Unused locals
- [X] Unknown fields of modules
- [ ] Discarding results from pcall/xpcall/other functions - [ ] Discarding results from pcall/xpcall/other functions
- [ ] `unpack` or `values` into a special - [ ] `unpack` or `values` into a special
- [ ] `do`/`values` with only one inner form - [ ] `do`/`values` with only one inner form
@ -67,7 +68,7 @@ Here is my feature wishlist. I don't expect to ever get all of this done, but th
- [ ] respond to signature help queries - [ ] respond to signature help queries
- [ ] hide or grey out the `self` in an `a:b` multisym call - [ ] hide or grey out the `self` in an `a:b` multisym call
- [ ] Go-to-references - [ ] Go-to-references
- [ ] lexical scope in the same file - [x] lexical scope in the same file
- [ ] fields - [ ] fields
- [ ] go to references of fields when tables are aliased - [ ] go to references of fields when tables are aliased
- [ ] global search across other files - [ ] global search across other files

9
src/fennel-ls/compiler.fnl
View File

@ -274,11 +274,12 @@ later by fennel-ls.language to answer requests from the client."
(each [_i form (ipairs (if macro-file? (ast->macro-ast ast) ast))] (each [_i form (ipairs (if macro-file? (ast->macro-ast ast) ast))]
(case (xpcall #(fennel.compile form opts) fennel.traceback) (case (xpcall #(fennel.compile form opts) fennel.traceback)
(where (or (nil err) (false err)) (not (err:find "^[^\n]-__NOT_AN_ERROR\n"))) (where (or (nil err) (false err)) (not (err:find "^[^\n]-__NOT_AN_ERROR\n")))
(if (os.getenv :TESTING)
(error (.. "\nYou have crashed the fennel compiler or fennel-ls with the following message\n:" err (error (.. "\nYou have crashed the fennel compiler or fennel-ls with the following message\n:" err
"\n\n^^^ the error message above here is the root problem\n\n")))) "\n\n^^^ the error message above here is the root problem\n\n"))
; (table.insert diagnostics (table.insert diagnostics
; {:range (message.pos->range 0 0 0 0) {:range (message.pos->range 0 0 0 0)
; :message (.. "unrecoverable compiler error: " err)}) :message (.. "unrecoverable compiler error: " err)}))))
(set fennel.macro-path old-macro-path)) (set fennel.macro-path old-macro-path))